feat: allow overriding entrypoint in RunJob #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taraspos
reviewed
Mar 2, 2025
| time.Sleep(200 * time.Millisecond) | ||
| container, err := job.getContainer() | ||
| c.Assert(err, IsNil) | ||
| c.Assert(container.Config.Entrypoint, DeepEquals, []string{"/bin/bash", "-c"}) |
There was a problem hiding this comment.
We would need two test cases for this, one with no Entrypoint provided to make sure that default value is honoured and another with entrypoint to make sure that default one is overwritten
There was a problem hiding this comment.
@taraspos sure, I will add the tests once I got the chance 👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will resolves #236
Please let me know if there's something I missed